Bug #7339
closedFailure when uploading to TK-8180
0%
Description
Chirp daily-20191110 (seen on Linux and Windows) fails when uploading to th-8180.
ERROR: General failure
Traceback (most recent call last):
File "/home/paul/Chirp/chirp-daily-20191110/chirp/drivers/tk8180.py", line 416, in sync_out
do_upload(self)
File "/home/paul/Chirp/chirp-daily-20191110/chirp/drivers/tk8180.py", line 355, in do_upload
status(addr)
File "/home/paul/Chirp/chirp-daily-20191110/chirp/drivers/tk8180.py", line 338, in status
LOG.debug('Radio address 0x%04x' % len(data))
NameError: global name 'data' is not defined
ERROR: -- Exception: --
ERROR: Traceback (most recent call last):
File "/home/paul/Chirp/chirp-daily-20191110/chirp/ui/clone.py", line 254, in run
self.__radio.sync_out()
File "/home/paul/Chirp/chirp-daily-20191110/chirp/drivers/tk8180.py", line 420, in sync_out
raise errors.RadioError('Failed to upload to radio: %s' % e)
RadioError: Failed to upload to radio: global name 'data' is not defined
ERROR: ----------------
ERROR: Clone failed: Failed to upload to radio: global name 'data' is not defined
ERROR: --- Exception Dialog: Failed to upload to radio: global name 'data' is not defined ---
ERROR: None
ERROR: ----------------------------
Changing line fixes it
--- chirp-daily-20191110/chirp/drivers/tk8180.py 2019-07-13 03:00:15.000000000 -0400
+++ chirp-daily-20191110fixed/chirp/drivers/tk8180.py 2019-11-14 16:41:09.177710945 -0500
@@ -335,7 +335,7 @@
status.max = radio._memsize
status.msg = "Cloning to radio"
radio.status_fn(status)
- LOG.debug('Radio address 0x%04x' % len(data))
LOG.debug('Radio address 0x%04x' % addr)for block in range(0, 0xBF + 1):
addr = block * 0x100
If I can get my hg going, I'll commit the change, If someone else does it first, I'm fine with it :-)
Updated by Paul Schmidt about 5 years ago
Diff didn't upload tight. Change line 330
from
LOG.debug('Radio address 0x%04x' % len(data))
to
LOG.debug('Radio address 0x%04x' % addr)
Updated by Dan Smith about 5 years ago
- Status changed from New to Closed
Thanks Paul, I wrote this driver in a weekend to scratch my own itch a while back. I dunno how I failed to re-test upload after fleshing out all the cosmetic stuff like that, so, my bad :)