Project

General

Profile

Actions
Copy link

Feature #230

open

Collect paste errors into single error message

Added by Sander Pool over 12 years ago. Updated almost 12 years ago.

Status:
In Progress
Priority:
Normal
Assignee:
Tom Hayward
Category:
-
Target version:
-
Start date:
07/01/2012
Due date:
% Done:

0%

Estimated time:
Chirp Version:
daily
Model affected:
(all models)
I read the instructions above:

Description

  • connect D710
  • paste data from attached .csv
  • lots of error dialogs appear that can only be dismissed in a single sequence (ie. dialogs appear modal) but the currently active one isn't necessary on top
  • need to kill CHIRP
  • there are several ways this could be prevented but they're probably hard to implement. It would be great if the paste/import stopped on the first error so that errors can be corrected without having to kill CHIRP.

CHIRP daily-20120529

Files

D710_lots.csv (26.6 KB) D710_lots.csv I think this is the .csv that caused problems Sander Pool, 07/01/2012 12:58 PM
Actions
Copy link
 #1

Updated by Dan Smith over 12 years ago

  • Subject changed from Uploading illegal data to D710 caused dozens of error dialogs to pile up, requiring a task kill to Uploading illegal data to D710 caused dozens of error dialogs
  • Status changed from New to Feedback
  • Assignee set to Tom Hayward
  • Target version set to 0.2.3

Please attach a debug log. Instructions are on the "how to file issues" page.

Actions
Copy link
 #2

Updated by Sander Pool over 12 years ago

Unfortunately the debug log is created new each time CHIRP starts rather than appending. I just started it to report an accurate version number so the debug log is not helpful in this case. I will try to repeat the issue at a later time and attach the debug log then.

Actions
Copy link
 #3

Updated by Dan Smith over 12 years ago

  • Status changed from Feedback to Blocked

The reset makes it much easier for us to examine individual issues. We'll take a look at this when you have the debug log information for us.

Thanks!

Actions
Copy link
 #4

Updated by Tom Hayward about 12 years ago

Reproduced by pasting 98-108 of the csv file. The debug log tells the whole story...

Exception running RadioJob: 159.8 is not in list
-- Exception: --
Traceback (most recent call last):
  File "/Users/tom/src/chirp.hg/chirpui/common.py", line 97, in _execute
    result = func(*self.args, **self.kwargs)
  File "/Users/tom/src/chirp.hg/chirp/kenwood_live.py", line 211, in set_memory
    spec = self._make_mem_spec(memory)
  File "/Users/tom/src/chirp.hg/chirp/kenwood_live.py", line 880, in _make_mem_spec
    "%02i" % (self._kenwood_valid_tones.index(mem.ctone)),
ValueError: 159.8 is not in list
------
Job Args:   (Memory[685],)
Job KWArgs: {}
Job Called from:
  File "./chirpw", line 133, in 
    gtk.main()
  File "/Users/tom/src/chirp.hg/chirpui/memedit.py", line 671, in mh
    changed = self.paste_selection()
  File "/Users/tom/src/chirp.hg/chirpui/memedit.py", line 1328, in paste_selection
    clipboard.request_text(self._paste_selection)
  File "/Users/tom/src/chirp.hg/chirpui/memedit.py", line 1322, in _paste_selection
    job = common.RadioJob(self._set_memory_cb, "set_memory", mem)

Exception running RadioJob: 159.8 is not in list
-- Exception: --
Traceback (most recent call last):
  File "/Users/tom/src/chirp.hg/chirpui/common.py", line 97, in _execute
    result = func(*self.args, **self.kwargs)
  File "/Users/tom/src/chirp.hg/chirp/kenwood_live.py", line 211, in set_memory
    spec = self._make_mem_spec(memory)
  File "/Users/tom/src/chirp.hg/chirp/kenwood_live.py", line 880, in _make_mem_spec
    "%02i" % (self._kenwood_valid_tones.index(mem.ctone)),
ValueError: 159.8 is not in list
------
Job Args:   (Memory[686],)
Job KWArgs: {}
Job Called from:
  File "./chirpw", line 133, in 
    gtk.main()
  File "/Users/tom/src/chirp.hg/chirpui/memedit.py", line 671, in mh
    changed = self.paste_selection()
  File "/Users/tom/src/chirp.hg/chirpui/memedit.py", line 1328, in paste_selection
    clipboard.request_text(self._paste_selection)
  File "/Users/tom/src/chirp.hg/chirpui/memedit.py", line 1322, in _paste_selection
    job = common.RadioJob(self._set_memory_cb, "set_memory", mem)

Exception running RadioJob: 159.8 is not in list
-- Exception: --
Traceback (most recent call last):
  File "/Users/tom/src/chirp.hg/chirpui/common.py", line 97, in _execute
    result = func(*self.args, **self.kwargs)
  File "/Users/tom/src/chirp.hg/chirp/kenwood_live.py", line 211, in set_memory
    spec = self._make_mem_spec(memory)
  File "/Users/tom/src/chirp.hg/chirp/kenwood_live.py", line 880, in _make_mem_spec
    "%02i" % (self._kenwood_valid_tones.index(mem.ctone)),
ValueError: 159.8 is not in list
------
Job Args:   (Memory[687],)
Job KWArgs: {}
Job Called from:
  File "./chirpw", line 133, in 
    gtk.main()
  File "/Users/tom/src/chirp.hg/chirpui/memedit.py", line 671, in mh
    changed = self.paste_selection()
  File "/Users/tom/src/chirp.hg/chirpui/memedit.py", line 1328, in paste_selection
    clipboard.request_text(self._paste_selection)
  File "/Users/tom/src/chirp.hg/chirpui/memedit.py", line 1322, in _paste_selection
    job = common.RadioJob(self._set_memory_cb, "set_memory", mem)

Exception running RadioJob: 159.8 is not in list
-- Exception: --
Traceback (most recent call last):
  File "/Users/tom/src/chirp.hg/chirpui/common.py", line 97, in _execute
    result = func(*self.args, **self.kwargs)
  File "/Users/tom/src/chirp.hg/chirp/kenwood_live.py", line 211, in set_memory
    spec = self._make_mem_spec(memory)
  File "/Users/tom/src/chirp.hg/chirp/kenwood_live.py", line 880, in _make_mem_spec
    "%02i" % (self._kenwood_valid_tones.index(mem.ctone)),
ValueError: 159.8 is not in list
------
Job Args:   (Memory[688],)
Job KWArgs: {}
Job Called from:
  File "./chirpw", line 133, in 
    gtk.main()
  File "/Users/tom/src/chirp.hg/chirpui/memedit.py", line 671, in mh
    changed = self.paste_selection()
  File "/Users/tom/src/chirp.hg/chirpui/memedit.py", line 1328, in paste_selection
    clipboard.request_text(self._paste_selection)
  File "/Users/tom/src/chirp.hg/chirpui/memedit.py", line 1322, in _paste_selection
    job = common.RadioJob(self._set_memory_cb, "set_memory", mem)

PC->RADIO: ME 689,0145050000,0,0,0,0,0,0,08,08,000,00000000,0,0000000000,0,0
D7->PC: ME
PC->RADIO: MN 689,W1HAD
D7->PC: MN 689,W1HAD
PC->RADIO: ME 690,0145030000,0,0,0,0,0,0,08,08,000,00000000,0,0000000000,0,0
D7->PC: ME
PC->RADIO: MN 690,W1FZG
D7->PC: MN 690,W1FZG
PC->RADIO: ME 691,0145030000,0,0,0,0,0,0,08,08,000,00000000,0,0000000000,0,0
D7->PC: ME
PC->RADIO: MN 691,N1OTW-10
D7->PC: MN 691,N1OTW-10
PC->RADIO: ME 692,0145030000,0,0,0,0,0,0,08,08,000,00000000,0,0000000000,0,0
D7->PC: ME
PC->RADIO: MN 692,W1GTT-10
D7->PC: MN 692,W1GTT-10
PC->RADIO: ME 693,0145050000,0,0,0,0,0,0,08,08,000,00000000,0,0000000000,0,0
D7->PC: ME
PC->RADIO: MN 693,W1OEM-10
D7->PC: MN 693,W1OEM-10
PC->RADIO: ME 694,0145070000,0,0,0,0,0,0,08,08,000,00000000,0,0000000000,0,0
D7->PC: ME
PC->RADIO: MN 694,WA2PNU
D7->PC: MN 694,WA2PNU
PC->RADIO: ME 695,0145050000,0,0,0,0,0,0,08,08,000,00000000,0,0000000000,0,0
D7->PC: ME
PC->RADIO: MN 695,N2NSA-10
D7->PC: MN 695,N2NSA-10

The errors say that the D710 does not accept 159.8 Hz as a CTCSS tone. This is true; the Kenwoods don't support this tone.

The dialogs can be dismissed by clicking OK, but there is some lag, so it's confusing. It would be more annoying had I pasted 100 rejected channels, not just 4 of 10.

The only thing that could be improved here is providing a better way to view multiple errors.

Actions
Copy link
 #5

Updated by Dan Smith about 12 years ago

  • Target version changed from 0.2.3 to 0.2.4
Actions
Copy link
 #6

Updated by Tom Hayward almost 12 years ago

  • Tracker changed from Bug to Feature
  • Subject changed from Uploading illegal data to D710 caused dozens of error dialogs to Collect import/export errors into single error message
  • Status changed from Blocked to In Progress
  • Target version changed from 0.2.4 to 0.3.0
  • Model affected changed from kenwood D710 to (all models)
Actions
Copy link
 #7

Updated by Tom Hayward almost 12 years ago

  • Subject changed from Collect import/export errors into single error message to Collect paste errors into single error message

Oops, mis-named this bug.

Actions
Copy link
 #8

Updated by Tom Hayward almost 12 years ago

  • Target version deleted (0.3.0)
Actions
Copy link

Also available in: Atom PDF

Copyright 2023 CHIRP Software LLC