Bug #11209
openseems some strings, for example "Name" and "Skip" columns are missing from translations.
Added by MELERIX . about 1 year ago. Updated 4 months ago.
100%
Description
and also, somehow some strings seems are being selft-translated by CHIRP itself, but how is that possible? I've tested it removing Spanish files from CHIRP manually and when I open it again it still shown some strings translated to Spanish, like if translation were hardcoded somewhere.
this is really weird xD
Files
file menu.png (120 KB) file menu.png | MELERIX ., 02/27/2024 10:45 PM | ||
edit menu.png (118 KB) edit menu.png | MELERIX ., 02/27/2024 10:45 PM | ||
name & skip columns.png (98.8 KB) name & skip columns.png | MELERIX ., 02/27/2024 10:45 PM | ||
ok & cancel buttons.png (105 KB) ok & cancel buttons.png | MELERIX ., 02/27/2024 10:45 PM | ||
help menu.png (116 KB) help menu.png | MELERIX ., 02/27/2024 10:45 PM | ||
clipboard-202402281654-mqg16.png (16.3 KB) clipboard-202402281654-mqg16.png | Dan Smith, 02/28/2024 04:54 PM |
Updated by Dan Smith about 1 year ago
Most of the things you're showing in the images are "stock items". They're things that are common to all applications (File->Exit, Copy, Paste, etc). Applications are supposed to use those things when possible because they automatically get things like translations, keyboard shortcuts. But also because automation tools (and screen readers) will issue commands to a window by name/function instead of clicking on the actual menu items.
As far as the Name and Skip columns, I'm not positive, but I suspect those are so simple that they're translated in the base code already and we're inheriting them. Not sure if I can prevent that. Is it a problem because they are the wrong "type" of name/skip?
Updated by MELERIX . about 1 year ago
well, the translation for "Name" at least is ok, but the translation for "Skip" is related with scan function so I think should be translated as "Omitir" instead of "Saltar".
Updated by Dan Smith about 1 year ago
Okay, so it's right in the translation file:
https://github.com/kk7ds/chirp/blob/master/chirp/locale/es.po#L3402
but it's just not getting used I guess. Hmm.
Updated by MELERIX . about 1 year ago
yes, there a lot of these strings already translated (maybe from older CHIRP versions) but seems the current CHIRP core is not making use of them.
Updated by Dan Smith about 1 year ago
Ah, it's commented out in the po file, I didn't realize. If I uncomment it and rebuild the catalog, I get the right string:
msgid "Skip"
msgstr "Omitir"
Updated by Dan Smith about 1 year ago
I can uncomment that one and push, but do you want to go through all the commented ones and uncomment those that you think should be applied?
Updated by MELERIX . about 1 year ago
for now I guess only with the ones I've reported here, unless something else is detected or needed in a future, because I have no idea how much of these are really used by the current CHIRP core and which ones are not.
Updated by Dan Smith about 1 year ago
- Status changed from New to Closed
- % Done changed from 0 to 100
Applied in changeset github|5cd1388e5b2d590cbb4992e7b8e2f02e26456b18.
Updated by MELERIX . about 1 year ago
btw, now using "chirp-next-20240312-win64" and seems the bug is back again, because the "Skip" column is being translated as "Saltar" but should be "Omitir".
Updated by Dan Smith about 1 year ago
Hmm, yeah:
https://github.com/kk7ds/chirp/blame/master/chirp/locale/es.po#L3413
For some reason the automatic refreshing of the .po file is commenting-out some of those translations instead of keeping them. I will have to do some more digging into what is going on there. I'm very busy with some other stuff this week, so it might not be soon. Don't let me forget though, I definitely want to get that resolved. Thanks for your diligence :)
Updated by Dan Smith about 1 year ago
- Status changed from Closed to In Progress
- Assignee set to Dan Smith
Updated by Dan Smith 4 months ago
Okay, @MELERIX . I think I finally figured out what's going on (with "Skip" at least). We don't actually mark "Skip" in the code for translation, so when you add it to the es.po
file, the next time we merge new strings into it, that string is commented-out as "old, no longer used". It was probably marked explicitly in the old version of the UI, but not the current one (we generate "Skip" from the code object Memory.skip
and thus never mark it).
So, I still think that re-translating the default items (File->New, File->Open, OK, Cancel, etc) is not expected by the framework since those are supposed to be platform-default strings. But, if there are other chirp-specific things like Skip that are not being translated, please help me identify them and I can apply the same tweak for those. I'll leave this open assuming there are more.
Thanks!