Hi Jim,

There appears to be a mis definition of dig_offset in ft857.py.

Looking through the settings menus on the radio, there was no value 768, so I temporarily expanded the range check to allow a value of 768 to be acceptable. After an upload, the value of 768 was displayed, as expected. Experimenting with the menu 39 setting, changing it to 10 gave a value of 256. This indicated to me that dig_offset was not a little endian 16 bit value, since the readios values were shifted 8 bits left, but instead it was a signed 8 bit value.

This change fixed the issue:
il16 dig_shift;

is modified to be:
u8 unknown15a;
i8 dig_shift;

I do not know if there is a way to submit this as a proper patch, but limited testing with a range of values seems to indicate it works on my radio,

Please advise if you think this change can be incorporated into Chirp daily builds.

Thanks,
Dale

Hi Dale
the field cannot be an i8 as otherwise it would store only values between +- 127.
Its probably an i16 instead of il16.

Probably the dig_disp field has the same error, can you please check it also?

Once tested I can produce the patch for you or, if you like, you can do it yourself; see DevelopersProcess

73 de IZ3GME Marco

Hi Filippi,

Of course you are right - i8 does not have the appropriate range. Thanks for catching my error.

Verified dig_disp has the same issue and that are no other uses of il16 in ft857.py. I changed both to i16 and check the maximum positive and negative values work properly.

Let me look into the developer process and post back here if I can't figure it out.

Thanks
Dale
W6EDT

I submitted a patch, but it is unclear wheter it was accepted. Essentially, the change was to modify 2 lines to use i16 instead of il16 in the ft857.py driver.

Hi Marco,

I sent an email to chirp_devel@intrepid.danplanet.com on November 21. I received a reply saying my post required moderation because I was not a member of the list, but I had thought that it would be picked up and processed.

I just now subscribed to the list and will post the patch below when I receive notification I was accepted.

Thanks,
Dale

HG changeset patch¶

User Dale Tyler chirp16@tylerent.com¶

Date 1479751087 28800¶

Mon Nov 21 09:58:07 2016 -0800¶

Node ID b28f9c9fd0b611706a3028000bbc82969298f1ba¶

Parent 9d973edb69b0ef502baa4ddb511db184eaaab3cb¶

Issue Number (#4239)
Fixes a problem with dig_disp (Menu 036) and dig_shift (Menu 039) where the entered
value would be mutiplied by 256 and thus would likely cause an exception due to a
range error. For example, a value of 30 would be interpreted (incorrectly) as 768
which is out of the acceptable range -300 <= x <= 300.

diff -r 9d973edb69b0 -r b28f9c9fd0b6 chirp/drivers/ft857.py
--- a/chirp/drivers/ft857.py Sat Nov 19 18:03:20 2016 -0800
+++ b/chirp/drivers/ft857.py Mon Nov 21 09:58:07 2016 -0800
@@ -189,8 +189,8 @@
pkt1200:7;
u8 unknown15:1,
pkt9600:7;

• il16 dig_shift;
• il16 dig_disp;
• i16 dig_shift;
• i16 dig_disp; i8 r_lsb_car; i8 r_usb_car; i8 t_lsb_car;

Fix committed - now available in latest hg pull