Bug #11904: Name column gets disabled (not reflected in UI) if extra is added to immutable - CHIRP

Actions

Copy link

Bug #11904

closed

Name column gets disabled (not reflected in UI) if extra is added to immutable

Added by Paul O. about 2 months ago. Updated about 2 months ago.

Status:

Closed

Priority:

Normal

Assignee:

Dan Smith

Category:

Target version:

Start date:

03/22/2025

Due date:

% Done:

100%

Estimated time:

Chirp Version:

Model affected:

RT-580G

Platform:

Windows

Debug Log:

test-debug.log test-debug.log

I read the instructions above:

Yes

Description

I think there is a bug with the immutable system. If you add "extra" to the list of immutable values your mem.extra fields get disabled as they should. But if you then try to edit the name of this channel you get a warning that extra is set to immutable. I think the name field should not get counted towards the extra fields but if, then it should also be disabled in UI.

Actions

Copy link

Updated by Dan Smith about 2 months ago

Assignee set to Dan Smith

Actions

Copy link

Updated by Dan Smith about 2 months ago

Okay, I see, you're adding extra to mem.immutable right? I think this is probably not the best way to do what you're trying to do, both because mem.extra isn't really a field in the same way and also because it would be an all-or-nothing sort of thing. Since mem.extra are RadioSetting let's use the same "mutable" flag on those to control it in the UI.

So you can go ahead and set that on your mem.extra things an I'll work on getting the UI to honor that for those columns, okay?

Actions

Copy link

Updated by Paul O. about 2 months ago

Dan Smith wrote in #note-2:

Okay, I see, you're adding extra to mem.immutable right? I think this is probably not the best way to do what you're trying to do, both because mem.extra isn't really a field in the same way and also because it would be an all-or-nothing sort of thing. Since mem.extra are RadioSetting let's use the same "mutable" flag on those to control it in the UI.

So you can go ahead and set that on your mem.extra things an I'll work on getting the UI to honor that for those columns, okay?

Okay so you mean you implement the option to disable the individual RadioSettings in the mem.extra like other columns so instead of extra I then add their short names to the list?

Actions

Copy link

Updated by Dan Smith about 2 months ago

No, setting values already have a set_mutable() method which lets you mark them as read-only. That's already honored in other places, just not in the blown-out memory column view. I've got a PR up that fixes that (https://github.com/kk7ds/chirp/pull/1300). It works for me, I was just waiting to see if you wanted to try it first, but I can go ahead and merge it if not.

Actions

Copy link

Updated by Paul O. about 2 months ago

Dan Smith wrote in #note-4:

No, setting values already have a set_mutable() method which lets you mark them as read-only. That's already honored in other places, just not in the blown-out memory column view. I've got a PR up that fixes that (https://github.com/kk7ds/chirp/pull/1300). It works for me, I was just waiting to see if you wanted to try it first, but I can go ahead and merge it if not.

Oh, okay. I just tested it without your patch which makes them immutable but not disabled in UI. I tested your commit and it fixes that. Now the UI reflects the mutablity of the extra values successfully.

Actions

Copy link